fyb/calcurse-edge
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use strcmp() instead of strncmp()

Browse Source 
strncmp() isn't intended to be a secure strcmp() replacement, it is
designed to be used if you want to compare the first n characters of two
strings. Since we always compare character pointers with string
literals, switch to using strcmp() everywhere.

Signed-off-by: Lukas Fleischer <calcurse@cryptocrack.de>
This commit is contained in:
Lukas Fleischer
2012-03-01 23:15:38 +01:00
parent 7072c9c88a
commit 2c9499bf27
5 changed files with 36 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/keys.c
View File

@@ -322,25 +322,25 @@ keys_str2int (char *key)
{
if (key[0] == '^')
return CTRL ((int)key[1]);
else if (!strncmp (key, CONTROL_KEY.str, CONTROL_KEY.len))
else if (!strcmp (key, CONTROL_KEY.str))
return CTRL ((int)key[CONTROL_KEY.len]);
else if (!strncmp (key, TAB_KEY.str, TAB_KEY.len))
else if (!strcmp (key, TAB_KEY.str))
return TAB;
else if (!strncmp (key, ESCAPE_KEY.str, ESCAPE_KEY.len))
else if (!strcmp (key, ESCAPE_KEY.str))
return ESCAPE;
else if (!strncmp (key, SPACE_KEY.str, SPACE_KEY.len))
else if (!strcmp (key, SPACE_KEY.str))
return SPACE;
else if (!strncmp (key, CURSES_KEY_UP.str, CURSES_KEY_UP.len))
else if (!strcmp (key, CURSES_KEY_UP.str))
return KEY_UP;
else if (!strncmp (key, CURSES_KEY_DOWN.str, CURSES_KEY_DOWN.len))
else if (!strcmp (key, CURSES_KEY_DOWN.str))
return KEY_DOWN;
else if (!strncmp (key, CURSES_KEY_LEFT.str, CURSES_KEY_LEFT.len))
else if (!strcmp (key, CURSES_KEY_LEFT.str))
return KEY_LEFT;
else if (!strncmp (key, CURSES_KEY_RIGHT.str, CURSES_KEY_RIGHT.len))
else if (!strcmp (key, CURSES_KEY_RIGHT.str))
return KEY_RIGHT;
else if (!strncmp (key, CURSES_KEY_HOME.str, CURSES_KEY_HOME.len))
else if (!strcmp (key, CURSES_KEY_HOME.str))
return KEY_HOME;
else if (!strncmp (key, CURSES_KEY_END.str, CURSES_KEY_END.len))
else if (!strcmp (key, CURSES_KEY_END.str))
return KEY_END;
else
return -1;