Fix window update after hook execution

The introduction of hooks raised a problem with window updates. The diagnosis
in commit feb059e8 (Fix segmentation fault on reload with pre-load hook) was
right, the cure was wrong.

The problem is wins_update(), not the listbox contents. The wins_update() call
does not belong in wins_unprepare_external() (or in io_reload_data()), but at a
higher level. It should be called _after_ reload, as indeed it is in
key_generic_reload() when the listbox contents have been updated (todo as well
as appointments). The call was introduced in commit 8ae75f3 without comment.

The todo updates in io_reload_data() also belong in key_generic_reload() where
they were before commit 7f06c252.

When saving data, all panels must be updated in case a hook was executed.

Signed-off-by: Lars Henriksen <LarsHenriksen@get2net.dk>
Signed-off-by: Lukas Fleischer <lfleischer@calcurse.org>

This commit is contained in:

Lars Henriksen

2018-08-20 20:22:24 +02:00

committed by

Lukas Fleischer

parent 37d8725e78

commit a94b0ecde0

3 changed files with 4 additions and 14 deletions

									
										1

src/wins.c
									
												View File
												
				@@ -613,7 +613,6 @@ void wins_unprepare_external(void)

					ui_mode = UI_CURSES;

					wins_refresh();

					wins_resize();

					wins_update(FLAG_ALL);

					if (notify_bar())

						notify_start_main_thread();

					if (conf.periodic_save > 0)

Fix window update after hook execution

1 src/wins.c Unescape Escape View File

1

src/wins.c

View File