Gracefully parse iCal parameters with colons

According to RFC 5545, iCalendar content lines can have optional
parameters, which can be quoted strings containing colons (":"). Make
sure that such colons are not interpreted as delimiters marking the
start of the value string.

Also, add a test case that covers this corner case.

Reported-by: Håkan Jerning <jerning@home.se>
Signed-off-by: Lukas Fleischer <lfleischer@calcurse.org>
This commit is contained in:
Lukas Fleischer
2017-02-07 17:52:14 +01:00
parent 3375fddb4e
commit e4e2e0eb20
4 changed files with 65 additions and 12 deletions

View File

@@ -49,6 +49,7 @@ TESTS = \
ical-005.sh \
ical-006.sh \
ical-007.sh \
ical-008.sh \
next-001.sh \
search-001.sh \
bug-002.sh \

12
test/data/ical-008.ical Normal file
View File

@@ -0,0 +1,12 @@
BEGIN:VCALENDAR
VERSION:2.0
BEGIN:VEVENT
DTSTART;TZID="(UTC+01:00) Amsterdam, Berlin, Bern, Rom, Stockholm, Wien":19800101T000100
DURATION:P1DT9H17M0S
SUMMARY:Calibrator's
END:VEVENT
BEGIN:VTODO
PRIORITY:1
SUMMARY:Nary parabled Louvre's fleetest mered
END:VTODO
END:VCALENDAR

28
test/ical-008.sh Executable file
View File

@@ -0,0 +1,28 @@
#!/bin/sh
. "${TEST_INIT:-./test-init.sh}"
if [ "$1" = 'actual' ]; then
mkdir .calcurse || exit 1
cp "$DATA_DIR/conf" .calcurse || exit 1
"$CALCURSE" -D "$PWD/.calcurse" -i "$DATA_DIR/ical-008.ical"
"$CALCURSE" -D "$PWD/.calcurse" -s01/01/1980 -r2
"$CALCURSE" -D "$PWD/.calcurse" -t
rm -rf .calcurse || exit 1
elif [ "$1" = 'expected' ]; then
cat <<EOD
Import process report: 0017 lines read
1 app / 0 events / 1 todo / 0 skipped
01/01/80:
- 00:01 -> ..:..
Calibrator's
01/02/80:
- ..:.. -> 09:18
Calibrator's
to do:
0. Nary parabled Louvre's fleetest mered
EOD
else
./run-test "$0"
fi