Remove SIGCHLD signal handler

The purpose is to make child_wait() reliable. The handler is meant for
the notify main thread, but signal handlers are shared by all threads.
In the calcurse main thread and the periodic save thread (hooks) the
handler and child_wait() will compete (if the signal handler kicks in
first, the waitpid() call in child_wait() will fail with errno ECHILD).

All child processes in the main thread, the notify thread, the periodic
save thread and the notify demon are explicitly waited for.

Signed-off-by: Lars Henriksen <LarsHenriksen@get2net.dk>
Signed-off-by: Lukas Fleischer <lfleischer@calcurse.org>

src/notify.c

@@ -34,6 +34,7 @@
  *
  */
 
+#include <sys/wait.h>
 #include <time.h>
 #include <stdlib.h>
 #include <string.h>
@@ -358,6 +359,9 @@ static void *notify_main_thread(void *arg)
 		pthread_mutex_unlock(&notify.mutex);
 		notify_update_bar();
 		psleep(thread_sleep);
+		/* Reap the user-defined notifications. */
+		while (waitpid(0, NULL, WNOHANG) > 0)
+			;
 		elapse += thread_sleep;
 		if (elapse >= check_app) {
 			elapse = 0;