yigid/openairinterface5g
1
0
Fork 0
mirror of https://gitlab.eurecom.fr/oai/openairinterface5g.git synced 2026-07-13 04:30:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix test log2_approx64.boundaries

Browse Source 
The test was actually never executed correctly (unsigned -10 is never <= 10), and log2_approx64_ref() was not accurate enough.
Therefore replace it by directly comparing one value above and one value below each rounding boundary.
This commit is contained in:
Thomas Schlichter
2024-10-02 11:21:09 +02:00
parent 6bf68c81c8
commit d6f9bcd1cc
1 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
openair1/PHY/TOOLS/tests/test_log2_approx.cpp
View File

@@ -10,11 +10,6 @@ uint8_t log2_approx_ref(uint32_t x)
return std::round(std::log2(x));
}
uint8_t log2_approx64_ref(unsigned long long int x)
{
return std::round(std::log2(static_cast<long double>(x)));
}
TEST(log2_approx, complete)
{
for (uint32_t i = 0; i < UINT32_MAX; i++)
@@ -23,12 +18,10 @@ TEST(log2_approx, complete)
TEST(log2_approx64, boundaries)
{
for (long double i = 0; i < 64; i++) {
unsigned long long i2 = std::pow(2.0L, i + 0.5L);
for (unsigned long long j = -10; j <= 10; j++) {
unsigned long long x = i2 + j;
EXPECT_EQ(log2_approx64(x), log2_approx64_ref(x));
}
for (int i = 0; i < 64; i++) {
unsigned long long int i2 = std::pow(2.0L, i + 0.5L);
EXPECT_EQ(log2_approx64(i2), i) << "log2(" << i2 << ")";
EXPECT_EQ(log2_approx64(i2 + 1), i + 1) << "log2(" << i2 + 1 << ")";
}
}